Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null safety #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Null safety #13

wants to merge 4 commits into from

Conversation

deakjahn
Copy link

@deakjahn deakjahn commented Mar 20, 2021

Minimal changes to support null safety. Also removes dependency on wifi package that lags behind, replacing it with a simple function call. Some deprecated functions also fixed.

@renanzdm
Copy link

several packages from this developer seem abandoned to me, it may be necessary to forked this package

@phan-dev
Copy link

Minimal changes to support null safety. Also removes dependency on wifi package that lags behind, replacing it with a simple function call. Some deprecated functions also fixed.

@deakjahn
Hi, does it work on iOS without wifi package?

@deakjahn
Copy link
Author

I only use it on Android so I can't really tell.

@machointossh
Copy link

@phan-dev FYI: I tried this branch and I'm confirmed the flutter_example worked fine on the iOS emulator. (iPhone 12 Pro Max; iOS 14.5)

@joeyw7
Copy link

joeyw7 commented Feb 28, 2022

For _getLocalIpAddress, maybe use this package instead. https://pub.dev/packages/network_info_plus

import 'package:network_info_plus/network_info_plus.dart';
final info = NetworkInfo();
var wifiIP = await info.getWifiIP(); 

@deakjahn
Copy link
Author

deakjahn commented Mar 1, 2022

@joeyw7 I tried to add it to my fork (https://github.com/deakjahn/ping_discover_network) but the package would need some refactoring to work well with the new Android embedding. I can't test on iOS, either. It wasn't my original intention to create a new independent fork, just to create the base PR but I don't know if this gets abandoned now here or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants